Skip to content

feat: Add auth for stac browser. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pantierra wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Add auth for stac browser. #376

pantierra wants to merge 7 commits into from

Conversation

@pantierra
Copy link
Contributor

@pantierra pantierra commented Dec 4, 2025 •
edited
Loading

Closes #371

@pantierra pantierra changed the title Add auth for stac browser. feat: Add auth for stac browser. Dec 4, 2025
@pantierra pantierra force-pushed the feature/stac-browser-auth branch 4 times, most recently from 2cb3e19 to e32e4d3 Compare December 4, 2025 14:47
@pantierra pantierra force-pushed the feature/stac-browser-auth branch 4 times, most recently from 49d5e83 to 61e1584 Compare December 15, 2025 15:24
@pantierra pantierra marked this pull request as ready for review December 15, 2025 15:58
ciaransweet
ciaransweet reviewed Dec 15, 2025
View reviewed changes
@pantierra pantierra force-pushed the feature/stac-browser-auth branch 3 times, most recently from 61e1584 to 1fbafd8 Compare December 15, 2025 19:31
@pantierra pantierra mentioned this pull request Dec 15, 2025
Open
@pantierra pantierra self-assigned this Dec 15, 2025
@pantierra pantierra marked this pull request as draft December 16, 2025 09:31
@pantierra
Copy link
Contributor Author

pantierra commented Dec 16, 2025

Went through it with @batpad and found some issues. Moved it to draft state again.

@pantierra pantierra force-pushed the feature/stac-browser-auth branch 8 times, most recently from 26314f3 to 7fca46d Compare December 19, 2025 12:53
@pantierra pantierra marked this pull request as ready for review December 19, 2025 12:57
@pantierra
Copy link
Contributor Author

pantierra commented Dec 19, 2025

  • Fixed the issues we saw.
  • Upgraded to stac-browser version 4.0.0

I think this is ready for review.

@pantierra pantierra requested a review from batpad December 19, 2025 12:59
@pantierra pantierra force-pushed the feature/stac-browser-auth branch 2 times, most recently from 8f89691 to 53e1f31 Compare December 19, 2025 13:11
ciaransweet
ciaransweet reviewed Dec 19, 2025
View reviewed changes
@pantierra pantierra force-pushed the feature/stac-browser-auth branch from 53e1f31 to d4ce130 Compare December 19, 2025 14:43
@pantierra pantierra force-pushed the feature/stac-browser-auth branch from d4ce130 to 280eec9 Compare December 19, 2025 14:43
ciaransweet
ciaransweet approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@ciaransweet ciaransweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pantierra pantierra mentioned this pull request Dec 19, 2025
Open
@pantierra
Copy link
Contributor Author

pantierra commented Dec 19, 2025

One integration test fails. alukach/mock-oidc-server#1 will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ciaransweet ciaransweet ciaransweet approved these changes

@alukach alukach Awaiting requested review from alukach

@batpad batpad Awaiting requested review from batpad

Assignees

@pantierra pantierra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get STAC browser to work with authentication enabled

3 participants

@pantierra @ciaransweet